revert: "fix: Add validation for transport types in ClientFactory"

[holtskinner]

Reverts #396

This PR shouldn't have been merged as we don't want to limit the protocol to only JSON-RPC, gRPC, and REST Transports. (e.g. for proprietary transport protocols)

Reported by @yarolegovich

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

[gemini-code-assist]

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that introduced strict validation for transport types within the ClientFactory. The original validation limited supported protocols to only JSON-RPC, gRPC, and REST, which was deemed too restrictive. By reverting this change, the system regains the flexibility to support a wider range of transport protocols, including proprietary ones, ensuring broader compatibility.

Highlights

• Transport Protocol Flexibility: Removes the validation logic in ClientFactory.create that previously restricted transport types to a predefined set (JSON-RPC, gRPC, REST), thereby re-enabling support for proprietary and other custom transport protocols.
• Code Reversion: Reverts the commit #396, specifically targeting the validation of transport types that was inadvertently merged.
• Test Suite Adjustment: Deletes the test_client_factory_invalid_transport_in_config test case, which was designed to verify the now-removed transport validation logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts a change that introduced strict validation for transport types in ClientFactory. The revert is well-justified by the need to support custom, proprietary transport protocols beyond the standard JSON-RPC, gRPC, and REST, thereby increasing the library's extensibility. The code changes correctly remove the validation logic and the associated tests. This change aligns the implementation with the documentation, which already allows for string-based custom transports. The changes are sound and I approve of this revert.