Skip to content

fix: convert auth_required state in proto utils #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeas1 merged 2 commits into from
Aug 29, 2025
Merged

fix: convert auth_required state in proto utils #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9802cb0
fix: convert auth_required state in proto utils
pilartomas Aug 29, 2025
cba5382
fixup! update test
pilartomas Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/a2a/utils/proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ def task_state(cls, state: types.TaskState) -> a2a_pb2.TaskState:
return a2a_pb2.TaskState.TASK_STATE_FAILED
case types.TaskState.input_required:
return a2a_pb2.TaskState.TASK_STATE_INPUT_REQUIRED
case types.TaskState.auth_required:
return a2a_pb2.TaskState.TASK_STATE_AUTH_REQUIRED
case _:
return a2a_pb2.TaskState.TASK_STATE_UNSPECIFIED

Expand Down Expand Up @@ -568,6 +570,8 @@ def task_state(cls, state: a2a_pb2.TaskState) -> types.TaskState:
return types.TaskState.failed
case a2a_pb2.TaskState.TASK_STATE_INPUT_REQUIRED:
return types.TaskState.input_required
case a2a_pb2.TaskState.TASK_STATE_AUTH_REQUIRED:
return types.TaskState.auth_required
case _:
return types.TaskState.unknown

Expand Down
6 changes: 1 addition & 5 deletions tests/utils/test_proto_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,7 @@ def test_enum_conversions(self):
)

for state in types.TaskState:
if state not in (
types.TaskState.unknown,
types.TaskState.rejected,
types.TaskState.auth_required,
):
if state not in (types.TaskState.unknown, types.TaskState.rejected):
proto_state = proto_utils.ToProto.task_state(state)
assert proto_utils.FromProto.task_state(proto_state) == state

Expand Down
Loading