-
Notifications
You must be signed in to change notification settings - Fork 336
feat: add auth header to push notifications #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add auth header to push notifications #644
Conversation
Summary of ChangesHello @Wondr-design, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the push notification system by integrating support for the 'Authorization' header. This allows for more robust and flexible authentication mechanisms, such as Bearer tokens, to be used when dispatching notifications. The change ensures that existing token-based authentication continues to function as expected, while providing a clear path for adopting modern authentication standards. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for an Authorization header in push notifications, which is a great feature enhancement. The implementation is clean, with new helper methods _build_headers and _authorization_header that neatly encapsulate the logic for header creation. The logic for preferring the 'Bearer' scheme is correctly implemented.
I've added one suggestion to improve test coverage for the new authentication logic to ensure its robustness against various edge cases. Overall, this is a solid contribution.
|
Follow-up: CI lint flagged _NoOp.enter return typing in src/a2a/utils/telemetry.py. Updated to use Self with a py3.10-safe typing_extensions import and added typing-extensions to core deps; uv.lock updated accordingly. |
|
Added edge-case coverage for _authorization_header: no credentials, empty schemes, non-Bearer scheme selection, empty-string scheme filtering, and validation error for None scheme entries. All tests in tests/server/tasks/test_push_notification_sender.py pass locally. |
|
All checks are green ✅ This PR is ready for review/merge when you have a moment. Happy to make any adjustments. |
Description
Testing
Fixes #585