-
Notifications
You must be signed in to change notification settings - Fork 341
test: add script to run DB integration tests locally #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the local development experience by providing a robust and flexible way to run integration tests. It sets up dedicated PostgreSQL and MySQL databases using Docker Compose, allowing developers to easily replicate the testing environment found in CI/CD pipelines. This change aims to streamline the process of troubleshooting database-related issues and validating changes against different database systems locally, improving developer productivity and code quality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a script for running integration tests locally using Docker Compose to set up PostgreSQL and MySQL databases. The changes are well-structured and provide useful features like debugging and selective database startup.
My review includes a few suggestions for improvement:
- In
docker-compose.test.yml, I've noted a minor security concern with how the MySQL password is provided in the healthcheck. - In
run_integration_tests.sh, I've suggested unsetting environment variables for a cleaner test run and generalizing the test selection to improve maintainability as more tests are added.
Overall, this is a great addition for local development and troubleshooting.
160b81a to
e41fc94
Compare
Description
Based on
unit-tests.yml.Supports:
--debugto start DB(s) without running tests (for selective running in IDE)--mysql,--postgresto use only one DB--stopto stop after running with--debugFrom project root:
Re #652 to troubleshoot failures