Skip to content

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Jan 30, 2026

Description

Based on unit-tests.yml.

Supports:

  • --debug to start DB(s) without running tests (for selective running in IDE)
  • --mysql, --postgres to use only one DB
  • --stop to stop after running with --debug

From project root:

./scripts/run_integration_tests.sh

Re #652 to troubleshoot failures

@ishymko ishymko requested a review from yarolegovich January 30, 2026 16:02
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the local development experience by providing a robust and flexible way to run integration tests. It sets up dedicated PostgreSQL and MySQL databases using Docker Compose, allowing developers to easily replicate the testing environment found in CI/CD pipelines. This change aims to streamline the process of troubleshooting database-related issues and validating changes against different database systems locally, improving developer productivity and code quality.

Highlights

  • New Local Integration Test Setup: Introduced a new docker-compose.test.yml file to define PostgreSQL and MySQL services for local integration testing, complete with health checks and environment variables.
  • Integration Test Runner Script: Added run_integration_tests.sh, a bash script that orchestrates the lifecycle of the test databases and executes specific integration tests. It supports arguments for debugging, stopping databases, and selecting specific database backends.
  • Flexible Test Execution: The new script allows running tests against only PostgreSQL or MySQL, or both by default. It also provides a --debug mode to keep databases running for manual inspection and a --stop option to shut them down.
  • Targeted Integration Tests: The script is configured to run integration tests specifically for test_database_task_store.py and test_database_push_notification_config_store.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ishymko ishymko marked this pull request as ready for review January 30, 2026 16:03
@ishymko ishymko requested a review from a team as a code owner January 30, 2026 16:03
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a script for running integration tests locally using Docker Compose to set up PostgreSQL and MySQL databases. The changes are well-structured and provide useful features like debugging and selective database startup.

My review includes a few suggestions for improvement:

  • In docker-compose.test.yml, I've noted a minor security concern with how the MySQL password is provided in the healthcheck.
  • In run_integration_tests.sh, I've suggested unsetting environment variables for a cleaner test run and generalizing the test selection to improve maintainability as more tests are added.

Overall, this is a great addition for local development and troubleshooting.

@ishymko ishymko force-pushed the ishymko/integration-tests-debug branch from 160b81a to e41fc94 Compare January 30, 2026 16:09
@ishymko ishymko changed the title test: add script to run integration tests locally test: add script to run DB integration tests locally Jan 30, 2026
@ishymko ishymko merged commit ffe31e2 into main Jan 30, 2026
13 checks passed
@ishymko ishymko deleted the ishymko/integration-tests-debug branch January 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants