chore: temporary freeze A2A repo ref in buf#699
Conversation
To resolve existing merge issues first.
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request temporarily freezes the reference for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request temporarily freezes the A2A repository reference in buf.gen.yaml to v1.0.0-rc to help resolve merge issues. The change is straightforward and makes sense given the context. I've added one minor suggestion to include a TODO comment to ensure this temporary change is reverted in the future.
| inputs: | ||
| - git_repo: https://github.com/a2aproject/A2A.git | ||
| ref: main | ||
| ref: v1.0.0-rc |
There was a problem hiding this comment.
Since this is a temporary freeze as mentioned in the PR title, it would be beneficial to add a TODO comment to remind developers to revert this change once the merge issues are resolved. This will help prevent this temporary pin from becoming permanent by mistake.
# TODO: Unfreeze this ref and point back to main once merge issues are resolved.
ref: v1.0.0-rcActive updates are happening to [A2A repo](https://github.com/a2aproject/A2A/commits/main/) currently. Switch `buf.gen.yaml` back to `main` (#699 switch it to the 1.0 RC tag to progress with merge without regenerating files) and update code to work with the latest changes.
Active updates are happening to [A2A repo](https://github.com/a2aproject/A2A/commits/main/) currently. Switch `buf.gen.yaml` back to `main` (#699 switched it to the 1.0 RC tag to progress with merge without regenerating files) and update code to work with the latest changes. Re #559.
To resolve existing merge issues first.
TBD: It should be pinned to some tag either way or better
bufinvocation shouldn't happen during the build as proto changes do not happen that often and can be maintained manually