Skip to content

test: fix role enum value in TCK SUT agent#725

Merged
ishymko merged 1 commit into1.0-devfrom
ishymko/fix-tck-sut
Feb 23, 2026
Merged

test: fix role enum value in TCK SUT agent#725
ishymko merged 1 commit into1.0-devfrom
ishymko/fix-tck-sut

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Feb 23, 2026

No description provided.

@ishymko ishymko marked this pull request as ready for review February 23, 2026 11:30
@ishymko ishymko requested a review from a team as a code owner February 23, 2026 11:30
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a consistency issue within the TCK SUT agent by standardizing the assignment of the role field. Instead of using a magic string, the change now leverages the Role enum, improving code clarity and reducing potential errors related to incorrect string values.

Highlights

  • Enum Import: The Role enum was imported into tck/sut_agent.py to allow for proper enum usage.
  • Role Enum Usage: The hardcoded string literal 'agent' for the role field in Message objects was replaced with the Role.ROLE_AGENT enum member, ensuring type safety and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the hardcoded string 'agent' with the Role.ROLE_AGENT enum value when creating Message objects in the SUT agent. This is a good improvement for type safety and code clarity. The changes are correct and well-implemented.

@ishymko ishymko merged commit 1d328e1 into 1.0-dev Feb 23, 2026
9 checks passed
@ishymko ishymko deleted the ishymko/fix-tck-sut branch February 23, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant