fix: replace stale entry in a2a.types.__all__ with actual import name#902
fix: replace stale entry in a2a.types.__all__ with actual import name#902
Conversation
….types.__all__ with ExtendedAgentCardNotConfiguredError
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical runtime error stemming from an incorrect export name in a module's 'all' definition. It rectifies the specific erroneous entry and proactively enhances the project's linting configuration to automatically detect and prevent similar issues in the future, ensuring better code maintainability and stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml to enable Ruff's preview mode and explicitly enable preview rules. Additionally, it modifies the src/a2a/types/__init__.py file to reflect a change in an error type, replacing AuthenticatedExtendedCardNotConfiguredError with ExtendedAgentCardNotConfiguredError in the module's public exports. There are no review comments to address.
🧪 Code Coverage (vs
|
__all__entry insrc/a2a/types/__init__.py:AuthenticatedExtendedCardNotConfiguredErrordoes not exist in the module namespace - the actual import isExtendedAgentCardNotConfiguredError. This causedAttributeErrorat runtime onfrom a2a.types import *or any direct reference to the listed name.__init__.pyfiles by addingpreview = trueandexplicit-preview-rules = trueunder[tool.ruff.lint]. This prevents stale__all__entries from going undetected in the future, without introducing any new preview-only rules.