ci: bump itk version and fix json rpc agent interface specification#938
Merged
ci: bump itk version and fix json rpc agent interface specification#938
Conversation
kdziedzic70
force-pushed
the
bump-tk-version
branch
from
ee79ca6 to
f5388f1
Compare
🧪 Code Coverage (vs
|
kdziedzic70
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the agent interfaces in itk/main.py to explicitly specify protocol versions '1.0' and '0.3' for JSON-RPC. The feedback suggests replacing these hardcoded strings with constants from a2a.utils to improve maintainability and ensure consistency with the SDK.
ishymko
approved these changes
Apr 7, 2026
ishymko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a bug that did not specify separate agent interfaces in SUT for jsonrpc transport - which resulted with go-v10 interface - communicating with python-v10 through v03 compat for jsonrpc
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕