Skip to content

test: add more scenarios to test_end_to_end#954

Merged
ishymko merged 5 commits into1.0-devfrom
ishymko/end-to-end-tests
Apr 9, 2026
Merged

test: add more scenarios to test_end_to_end#954
ishymko merged 5 commits into1.0-devfrom
ishymko/end-to-end-tests

Conversation

@ishymko
Copy link
Copy Markdown
Member

@ishymko ishymko commented Apr 9, 2026

Based on https://a2a-protocol.org/latest/specification/#312-send-streaming-message:

  1. Message based flow.
  2. Emit Task as a first event.

TODO: switches to the old request handler as there are known issues in the new one

With a new handler failures are caused by

  1. Task events are not streamed
  2. return_immediately + direct message - V2 returns a phantom Task before the executor produces its Message

ishymko added 2 commits April 9, 2026 10:31
Based on https://a2a-protocol.org/latest/specification/#312-send-streaming-message:
1. `Message` based flow.
2. Emit `Task` as a first event.

WIP: switches to the old request handler as there are known issues in the new one.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🧪 Code Coverage (vs 1.0-dev)

⬇️ Download Full Report

Base PR Delta
src/a2a/client/base_client.py 92.59% 95.56% 🟢 +2.96%
src/a2a/server/agent_execution/active_task.py 93.40% 94.06% 🟢 +0.66%
src/a2a/server/request_handlers/default_request_handler.py 97.82% 98.13% 🟢 +0.31%
src/a2a/server/tasks/task_manager.py 97.44% 98.29% 🟢 +0.85%
Total 92.23% 92.33% 🟢 +0.09%

Generated by coverage-comment.yml

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the MockAgentExecutor to support direct message responses without creating a task, and updates the task creation and status update logic. It introduces a LegacyRequestHandler and adjusts imports accordingly. Existing end-to-end tests were updated to align with the new task event structure and the removal of the explicit 'task submitted' message from the history. Additionally, new end-to-end tests were added to cover the direct message response functionality across different client configurations (blocking, streaming, and return_immediately). The review suggests combining the newly added direct message tests into a single parameterized test to improve maintainability and reduce code duplication, referencing a style guide rule about test class definition.

@ishymko ishymko marked this pull request as ready for review April 9, 2026 13:59
@ishymko ishymko requested a review from a team as a code owner April 9, 2026 13:59
@ishymko ishymko merged commit a669521 into 1.0-dev Apr 9, 2026
18 checks passed
@ishymko ishymko deleted the ishymko/end-to-end-tests branch April 9, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants