fix: Don't generate empty metadata change events in VertexTaskStore#974
Merged
gaborfeher merged 2 commits intoa2aproject:1.0-devfrom Apr 16, 2026
Merged
fix: Don't generate empty metadata change events in VertexTaskStore#974gaborfeher merged 2 commits intoa2aproject:1.0-devfrom
gaborfeher merged 2 commits intoa2aproject:1.0-devfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the VertexTaskStore to prevent generating metadata change events when metadata transitions between empty values, such as {} and None. While the logic change is sound, the newly added test case contains several critical issues: it misses the required ServerCallContext argument in method calls, incorrectly uses Pydantic-style methods on Protobuf objects, and attempts invalid assignments to Protobuf map fields. A code suggestion has been provided to align the test with the project's Protobuf-based architecture.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/contrib/tasks/vertex_task_store.py | 90.98% | 94.74% | 🟢 +3.76% |
| Total | 92.53% | 92.59% | 🟢 +0.06% |
Generated by coverage-comment.yml
ishymko
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #802