fix: update with_a2a_extensions to append instead of overwriting#985
Merged
fix: update with_a2a_extensions to append instead of overwriting#985
with_a2a_extensions to append instead of overwriting#985Conversation
ishymko
changed the title
with_a2a_extensions to append instead of overwriting
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/service_parameters.py | 95.24% | 100.00% | 🟢 +4.76% |
| src/a2a/server/events/event_queue_v2.py | 91.71% | 91.19% | 🔴 -0.52% |
| src/a2a/utils/telemetry.py | 91.41% | 90.63% | 🔴 -0.78% |
| Total | 92.62% | 92.61% | 🔴 -0.01% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the with_a2a_extensions function to merge and deduplicate extension URIs with existing headers, ensuring a stable sorted order. It also introduces a comprehensive test suite for these changes. Feedback was provided to enhance the robustness of the merging logic by consistently applying the get_requested_extensions helper to all inputs and simplifying the implementation.
guglielmo-san
approved these changes
Apr 17, 2026
ishymko
pushed a commit
that referenced
this pull request
Apr 17, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0-alpha.3](v1.0.0-alpha.2...v1.0.0-alpha.3) (2026-04-17) ### Bug Fixes * update `with_a2a_extensions` to append instead of overwriting ([#985](#985)) ([e1d0e7a](e1d0e7a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing extensions are kept, enables better modularity of service parameters updates by (for instance) multiple interceptors.