Only allow public properties when building a schema.#25
Merged
jeggy merged 2 commits intoaPureBase:masterfrom May 26, 2019
nielsvanvelzen:ignore-private-properties
Merged
Only allow public properties when building a schema.#25jeggy merged 2 commits intoaPureBase:masterfrom nielsvanvelzen:ignore-private-properties
jeggy merged 2 commits intoaPureBase:masterfrom
nielsvanvelzen:ignore-private-properties
Conversation
This fixes crashes when trying to query private/protected fields.
Member
|
Thanks! This looks great, it would be great if you could provide a simple unit test validating that a private field would be ignored |
Author
|
Thanks for the fast reply! I added a unit test that checks if a private field is not in the schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes crashes when trying to query private/protected fields.