Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow public properties when building a schema. #25

Merged
merged 2 commits into from May 26, 2019

Conversation

Projects
None yet
2 participants
@nielsvanvelzen
Copy link

commented May 26, 2019

This fixes crashes when trying to query private/protected fields.

Only allow public properties when building a schema.
This fixes crashes when trying to query private/protected fields.
@jeggy

This comment has been minimized.

Copy link

commented May 26, 2019

Thanks!

This looks great, it would be great if you could provide a simple unit test validating that a private field would be ignored

@nielsvanvelzen

This comment has been minimized.

Copy link
Author

commented May 26, 2019

Thanks for the fast reply! I added a unit test that checks if a private field is not in the schema.
If something is missing please let me know.

@jeggy jeggy merged commit f4578dc into aPureBase:master May 26, 2019

1 check passed

codebeat no reportable quality changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.