fix: EC3 image handling, preflight, and chart correctness#44
Merged
aa-replicated merged 1 commit intomainfrom Apr 17, 2026
Merged
fix: EC3 image handling, preflight, and chart correctness#44aa-replicated merged 1 commit intomainfrom
aa-replicated merged 1 commit intomainfrom
Conversation
- helmchart.yaml: use ReplicatedImageRegistry/Repository for proper online vs airgap image routing; remove broken IsEmbeddedCluster function and preflight.excludeReachability block - deployment.yaml: support image.registry/repository split (EC path) with imageProxy fallback for direct Helm installs - values.yaml: add image.registry default, remove excludeReachability - preflight.yaml: remove excludeReachability excludes, change reachability fail->warn so airgap installs are not blocked Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplicatedImageRegistry/ReplicatedImageRepositoryfunctions for proper online vs airgap image routingIsEmbeddedClusterKOTS function that was blocking EC installsdb-connection-checkfileName path (flat, not subdirectory)*/gameshelf.lognotgameshelf-app/*.log)app.kubernetes.io/name=replicated)volumePermissions.image.registryfor EC installsintegrationLicenseIDfrom EC values (SDK gets license via proper injection)pr-N)Test plan
🤖 Generated with Claude Code