Skip to content

Conversation

@ssk090
Copy link
Contributor

@ssk090 ssk090 commented Jun 27, 2024

Pull Request Summary

image image

@vercel
Copy link

vercel bot commented Jun 27, 2024

@ssk090 is attempting to deploy a commit to the FirstIssues Team on Vercel.

A member of the Team first needs to authorize it.

@ssk090 ssk090 mentioned this pull request Jun 27, 2024
@vercel
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firstissues ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:20am

@aadeshkulkarni
Copy link
Owner

aadeshkulkarni commented Jun 28, 2024

Nicely done.

Here are few issues:

  • It should be FirstIssues instead of Good First issues
  • The feedback form is visible after scrolling down. Can we take it up, may be a two column layout for desktop and something else for mobile ?
  • Add a feedback link to the home page below Browse by language section.
Screenshot 2024-06-28 at 3 56 43 PM

@KrupaPanchal2527 - Please take a second pass of review, add suggestions, if any.

@KrupaPanchal2527 KrupaPanchal2527 self-requested a review June 28, 2024 10:35
@KrupaPanchal2527
Copy link
Collaborator

Overall looks really good. Few points from my end -

  1. Let's show the feedback form submission message in an alert/toast which will be dismissed automatically after few seconds.
    image

  2. Disable the Submit button while feedback is being saved to the server - this way we can avoid

  3. I would also like to accept email as an input - this way it would enable us to reach out to people in case further discussion/suggestions are needed.

@ssk090
Copy link
Contributor Author

ssk090 commented Jun 28, 2024

on it 🫡

ssk090 added 2 commits July 1, 2024 19:36
- Updated the feedback form with email field.
- Created a new route for the feedback form.
- Added toast message for the feedback submit button.
@ssk090
Copy link
Contributor Author

ssk090 commented Jul 1, 2024

  • Updated the feedback form with email field.
  • Created a new route for the feedback form. (You can go to /feedback to access the form)
  • Added toast message for the feedback submit button.
  • The submit button gets disabled when the data is getting saved into the server.
  • Fields are cleared after submission.
  • Update project name to "First Issues" instead of "Good First Issues" in about page and read me
image

@ssk090
Copy link
Contributor Author

ssk090 commented Jul 1, 2024

Hey @KrupaPanchal2527 / @aadeshkulkarni, I have updated the branch according to the required changes. Do let me know if any further changes are required. Thank You!

@KrupaPanchal2527
Copy link
Collaborator

@ssk090 Changes looks great. Thanks for getting this in.
I think the feedback form will help us get suggestions and feedback for our application which will be a really good thing!

I have made some minor change -

  • Moved email field to new line
  • Renamed the feedback form file name to follow the other files naming convention

@KrupaPanchal2527 KrupaPanchal2527 merged commit 905a3ad into aadeshkulkarni:main Jul 2, 2024
@ssk090
Copy link
Contributor Author

ssk090 commented Jul 2, 2024

Thank you for the feedback! I'm glad the changes look good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement | User feedback

3 participants