Skip to content

Conversation

@mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Feb 21, 2025

Description

This PR fixes recurrent issues with a test for sampled batches.

Changes

  • Instead of using a valuation, reduce the scope of the test to the actual batching
  • Also test skip_indices with batches (and add support for a couple of methods which was already there)

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@mdbenito mdbenito merged commit 5659ca8 into develop Feb 21, 2025
39 checks passed
@mdbenito mdbenito deleted the fix/batching_and_skip_index_tests branch February 21, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants