Properly return installed games on Windows#18
Merged
aanderse merged 1 commit intoaanderse:masterfrom Mar 8, 2020
AmineI:patch-1
Merged
Properly return installed games on Windows#18aanderse merged 1 commit intoaanderse:masterfrom AmineI:patch-1
aanderse merged 1 commit intoaanderse:masterfrom
AmineI:patch-1
Conversation
aanderse
approved these changes
Mar 8, 2020
Owner
aanderse
left a comment
There was a problem hiding this comment.
I can't test, but nothing jumps out as out of place... I'm certain all the Windows users appreciate you fixing this!
Collaborator
Author
I did check on my end before submitting the PR, so it should be good to go, but I'll stay around in case it was one of those "It works on my machine" type of issues ;) . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17 .
As mentioned there, I kept the original function structure and return values (ie
get_registry_valuesreturns a dict of installed games only, even though the registry contains uninstalled game keys.) , but the name is a bit confusing considering what the function actually does.If it seems good to you, I'd recommend refactoring
get_registry_valuesto actually return a dict of all Steam registry values, differently on Windows and Linux. Then aget_installed_gamesfunction would callget_registry_valuesand filter the dict of games, keeping only the installed ones. That should improve clarity and also reduce a bit the amount of code to maintain differently between Windows and Linux.Just a suggestion of course, no worries if you feel like it's fine as it is :)