Skip to content

Properly return installed games on Windows#18

Merged
aanderse merged 1 commit intoaanderse:masterfrom
AmineI:patch-1
Mar 8, 2020
Merged

Properly return installed games on Windows#18
aanderse merged 1 commit intoaanderse:masterfrom
AmineI:patch-1

Conversation

@AmineI
Copy link
Copy Markdown
Collaborator

@AmineI AmineI commented Mar 8, 2020

Fixes #17 .

As mentioned there, I kept the original function structure and return values (ie get_registry_values returns a dict of installed games only, even though the registry contains uninstalled game keys.) , but the name is a bit confusing considering what the function actually does.

If it seems good to you, I'd recommend refactoring get_registry_values to actually return a dict of all Steam registry values, differently on Windows and Linux. Then a get_installed_games function would call get_registry_values and filter the dict of games, keeping only the installed ones. That should improve clarity and also reduce a bit the amount of code to maintain differently between Windows and Linux.

Just a suggestion of course, no worries if you feel like it's fine as it is :)

Copy link
Copy Markdown
Owner

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test, but nothing jumps out as out of place... I'm certain all the Windows users appreciate you fixing this!

@aanderse aanderse merged commit 22c13c2 into aanderse:master Mar 8, 2020
@AmineI
Copy link
Copy Markdown
Collaborator Author

AmineI commented Mar 8, 2020

I can't test, but nothing jumps out as out of place... I'm certain all the Windows users appreciate you fixing this!

I did check on my end before submitting the PR, so it should be good to go, but I'll stay around in case it was one of those "It works on my machine" type of issues ;) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninstalled games shown in "Installed games"

2 participants