Major refactoring of the code base#23
Major refactoring of the code base#23aanderse merged 15 commits intoaanderse:masterfrom AmineI:refactor
Conversation
…esence of steam id & api key
With the log function in there, it was already not much of a "config" file before I added other functions
…tion. Pre-filter the installed games dictionary to suit the function correctly Finish removing handles
the function "all" overshadowed a builtin function, which led to renaming it to all_games, along with the other routes' functions. Auto-format of the document according to PEP-8 rules Exp==False -> not Exp
…ed_steam_games. Also improved error handling in there.
|
@AmineI wonderful! I'll test this today or tomorrow and merge. I really appreciate your work on this plugin 🎉 |
|
You're welcome, hopefully that will make the plugin easier to improve and maintain, and more developer friendly. Don't hesitate to ask me if a change I made doesn't seem logical to you, and I'll explain/add comments / revert :) . |
|
Amazing work! Thank you for your time and energy on this 🎉 I've extended an invite on this repo to you if you're interested. |
My pleasure ! I accepted the invite, thanks ! I'll continue sending PRs and not directly writing to master of course, but I'll be sure to continue watching any issues or PR coming on this repo 😄 |
2 participants
Essentially eliminates duplicate code and document it
There is a commit adding whitespaces and more to follow Python's official PEP8 conventions. I think it can be easily reverted if you prefer to keep your own styling.
Fixes #21, fixes #9 .
I would recommend reviewing each commit individually, as Github seems a bit lost in the full changelist.
All changes were tested in Kodi on my Windows machine, besides Linux installed games detection (I have tested it manually in the console with a registry.vdf file found online, but I'd still prefer a real test to be done on a Kodi install)