Skip to content

Fixed UnicodeDecodeError when the registry contains unicode#33

Merged
aanderse merged 1 commit intomasterfrom
unknown repository
Aug 15, 2022
Merged

Fixed UnicodeDecodeError when the registry contains unicode#33
aanderse merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 5, 2022

No description provided.

@aanderse
Copy link
Copy Markdown
Owner

Hi @Turpster 👋

Thanks for the PR. Sorry I haven't responded until now. Change looks fine. This is all tested and good to merge?

@Oro
Copy link
Copy Markdown

Oro commented Aug 15, 2022

fwiw, I can confirm that this patch works for me.
Without this patch I was unable to open up the "Installed Games" page, with it it works.

I am atm using the following nixpkgs overlay to patch it:

          (steam-library.overrideAttrs (oldAttrs: rec {
            patches = (pkgs.fetchpatch {
              url = "https://github.com/aanderse/plugin.program.steam.library/commit/e3c5b8676f0fec13bb1240e2a53ab9a7a5819322.patch";
              sha256 = "sha256-BwC8FknFxqr5lqMQ8sn8tyJLUrnCmrQCW6vT0mYnynA=";
            });
          }))

For completeness' sake: Kodi log without the patch opening up the library, I assume it is due to a ® (as in Spiritfarer®: Farewell Edition) but cannot confirm that hunch:

2022-08-15 14:42:52.964 T:123610    INFO <general>: Skipped 3 duplicate messages..
2022-08-15 14:42:52.964 T:123610   ERROR <general>: [plugin.program.steam.library] Error while reading Steam VDF file <_io.TextIOWrapper name='/home/oro/.steam/registry.vdf' mode='r' encoding='ANSI_X3.4-1968'>. Returning {}
2022-08-15 14:42:52.964 T:123610   ERROR <general>: [plugin.program.steam.library] 'registry'
2022-08-15 14:42:52.965 T:123610    INFO <general>: CPythonInvoker(5, /nix/store/brhj8a760pdlmr7dyczzcgi4263dfh32-kodi-19.4-env/share/kodi/addons/plugin.program.steam.library/addon.py): script successfully run
2022-08-15 14:42:52.975 T:123610    INFO <general>: Python interpreter stopped

@aanderse aanderse merged commit 6082943 into aanderse:master Aug 15, 2022
@aanderse
Copy link
Copy Markdown
Owner

Thanks you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants