Merged
Conversation
… and their abstraction-based conformance checking
… and their abstraction-based conformance checking
…thub.com/aarkue/rust4pm into object-centric-conformance-process-trees
…onal if it is already related
aarkue
requested changes
Jun 17, 2025
Owner
aarkue
left a comment
aarkue
left a comment
There was a problem hiding this comment.
Nice implementation, there are only a few comments 😄
Overall, I think it would be good to separate most of the functionality more clearly into modules (e.g., ocpt), as it feels to be rather specific to that. Also, this would allow more easily adding more ocpt-related implementations inside this module in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.