Conversation
aarkue
reviewed
Jul 29, 2025
Owner
aarkue
left a comment
aarkue
left a comment
There was a problem hiding this comment.
I took the liberty to merge main into this branch and fix a few of the (new) formatting/linting rules.
The only issues I have are regarding the UUIDs / tree structure implementation. Maybe there is a good reason for them that I currently don't see, but we can also discuss this in more detail later.
`From<Vec<Attribute>>` is ambiguous since it _could_ be interpreted as a List or Container. Currently, a List is assumed.
`attribute`, `attributes`, `event`, `trace`, `log`,
Since without the semicolon, a `[` would follow a `{`, there is no
reason to require a semicolon.
For now, this has been made optional, but all examples still use a
semicolon
Otherwise, the macros would only work if the user has chrono as a dependency.
trace ids and manual, integer, trace ids
For instance, the invocation `event_log!(["a"], ["b"] {"concept:name" =>
0})` has two traces with trace id `0`.
- Implement `From<_>` for `AttributeValue`
- Re-export `chrono`
- Add macros for event log creation. For instance:
```rust
attribute!("concept:name" => "Approve");
attributes!(
"concept:name" => "Approve",
"time:timestamp" => chrono::Utc::now()
);
event!("a");
event!("b"; {"org:resource" => "John"});
trace!("a", "b", "c", "d");
trace!(
{"outcome" => "approved"};
"a"; {"time:timestamp" => chrono::Utc::now()}, "b", "c", "d"
);
event_log!(
["a", "b", "c", "d"],
["a", "c", "b", "d"],
);
event_log!(
{"created_at" => chrono::Utc::now()};
["a", "b", "c", "d"] {"approved" => true},
["a", "c"; {"org:resource" => "John"}, "b", "d"],
);
```
Owner
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.