chore: improve text around sgho #2542

foodaka · 2025-07-18T10:58:42Z

General Changes

Improve language around sgho rewards
updates merit token for sgho

Developer Notes

Add any notes here that may be helpful for reviewers.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

vercel · 2025-07-18T10:58:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2025 4:41pm

github-actions · 2025-07-18T11:05:38Z

Ipfs hash: bafybeigle7nhoikoofbaa37omzmxa2qhxjkbwfkh7cvkxywnalgtwqxz34
Ipfs preview link: https://bafybeigle7nhoikoofbaa37omzmxa2qhxjkbwfkh7cvkxywnalgtwqxz34.ipfs.cf-ipfs.com/

github-actions · 2025-07-18T11:05:43Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina

does it require to run i18n?

NandyBa · 2025-07-18T15:41:46Z

src/modules/reserve-overview/Gho/SavingsGho.tsx

      <Typography gutterBottom>
        Stake GHO is now Savings GHO. With no risk of slashing and immediate withdraws available,
-        earn up to {aprFormatted}%.
+        earn up to {aprFormatted}% APY and claim rewards weekly.


Wrong it's APR not APY

updated, thanks

NandyBa · 2025-07-18T15:46:01Z

src/hooks/useMeritIncentives.ts

    GHO: [
      {
        action: MeritAction.ETHEREUM_SGHO,
        rewardTokenAddress: AaveV3Ethereum.ASSETS.GHO.UNDERLYING,


Must also be changed

good catch added in 399852a

I was currently checking the other campaigns and it seems some of the campaign have wrong rewardTokenAddress.
But it seems we don't really use it, so it's not. major issue

MartinGbz · 2025-07-18T15:42:11Z

src/hooks/useMeritIncentives.ts

    GHO: [
      {
        action: MeritAction.ETHEREUM_SGHO,
        rewardTokenAddress: AaveV3Ethereum.ASSETS.GHO.UNDERLYING,


We should use AaveSafetyModule.STK_GHO (former stkGHO <> current sGHO) instead of AaveV3Ethereum.ASSETS.GHO.UNDERLYING

yeah missed that one thanks updated in 399852a

already fixed in 399852a

github-actions · 2025-07-18T15:56:07Z

Ipfs hash: bafybeif3mmhpyjnhucd7226mu2xcjqwj3oxv4fzcwfynap37ws7cvsctzi
Ipfs preview link: https://bafybeif3mmhpyjnhucd7226mu2xcjqwj3oxv4fzcwfynap37ws7cvsctzi.ipfs.cf-ipfs.com/

github-actions · 2025-07-18T15:56:10Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

NandyBa

Can you update name here ? ALso it may be a good idea to remove stacking APR here as sGHO is not expected to receive stacking

foodaka · 2025-07-18T16:20:33Z

@NandyBa removed based on your feedback

NandyBa · 2025-07-18T16:24:20Z

@NandyBa removed based on your feedback

Thanks. We still display 0%

github-actions · 2025-07-18T16:25:57Z

Ipfs hash: bafybeifdfn7vc4fsxvemyyzwibbrjan3h6uz6jfmbfdrwqlfcd3y5xl3wy
Ipfs preview link: https://bafybeifdfn7vc4fsxvemyyzwibbrjan3h6uz6jfmbfdrwqlfcd3y5xl3wy.ipfs.cf-ipfs.com/

github-actions · 2025-07-18T16:26:01Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina · 2025-07-18T16:44:20Z

src/modules/staking/GhoStakingPanel.tsx

              color={xsm ? 'text.secondary' : 'text.primary'}
            >
-              <Trans>Deposit APR</Trans>
+              <Trans>Deposit APR </Trans>


github-actions · 2025-07-18T16:45:05Z

Ipfs hash: bafybeiezxr3d7dmqsa3dnbgiaujowncvyshqbp2jowbxyansjil3hdobui
Ipfs preview link: https://bafybeiezxr3d7dmqsa3dnbgiaujowncvyshqbp2jowbxyansjil3hdobui.ipfs.cf-ipfs.com/

github-actions · 2025-07-18T16:45:16Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

NandyBa · 2025-07-18T16:46:00Z

When wallet is not connected it's still display GHO. Maybe change it for sGHO to be consistant with when user is connected

foodaka added 2 commits July 18, 2025 11:47

chore: improve text around sgho

29f2c70

chore: fix text

ee64346

vercel bot deployed to Preview July 18, 2025 11:02 View deployment

mgrabina previously approved these changes Jul 18, 2025

View reviewed changes

fix: sgho rewards

8cacfc2

foodaka dismissed mgrabina’s stale review via 8cacfc2 July 18, 2025 15:37

vercel bot deployed to Preview July 18, 2025 15:40 View deployment

NandyBa reviewed Jul 18, 2025

View reviewed changes

fix: typo

9b1ba17

NandyBa reviewed Jul 18, 2025

View reviewed changes

vercel bot deployed to Preview July 18, 2025 15:48 View deployment

fix: reward token

399852a

MartinGbz reviewed Jul 18, 2025

View reviewed changes

vercel bot deployed to Preview July 18, 2025 15:52 View deployment

NandyBa reviewed Jul 18, 2025

View reviewed changes

fix: remove staking info gho unconnected wallet

6da476a

vercel bot deployed to Preview July 18, 2025 16:22 View deployment

fix: gho incentive info

b89bbd2

vercel bot deployed to Preview July 18, 2025 16:41 View deployment

mgrabina reviewed Jul 18, 2025

View reviewed changes

mgrabina approved these changes Jul 18, 2025

View reviewed changes

JoaquinBattilana approved these changes Jul 18, 2025

View reviewed changes

foodaka merged commit 2a99224 into main Jul 18, 2025
22 of 24 checks passed

foodaka deleted the chore/sgho-text branch July 18, 2025 17:07

chore: improve text around sgho #2542

chore: improve text around sgho #2542

Uh oh!

Conversation

foodaka commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

vercel bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

mgrabina left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

NandyBa left a comment

Choose a reason for hiding this comment

Uh oh!

foodaka commented Jul 18, 2025

Uh oh!

NandyBa commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

NandyBa commented Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

foodaka commented Jul 18, 2025 •

edited

Loading

vercel bot commented Jul 18, 2025 •

edited

Loading