Refactor/reserve overview page sdk #2698
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| const borrowCapReached = asset?.borrowInfo?.borrowCapReached || rawUsage >= 99.99; | ||
|
|
||
| return { | ||
| borrowCapUsage: Number.isFinite(rawUsage) ? rawUsage : 0, |
There was a problem hiding this comment.
when does it go into the 0 block?
There was a problem hiding this comment.
if the cap is zero and the supplied != 0 (e.g. after a gov freeze), shouldn't usage be 100%?
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| const borrowCapReached = asset?.borrowInfo?.borrowCapReached || rawUsage >= 99.99; | ||
|
|
||
| return { | ||
| borrowCapUsage: Number.isFinite(rawUsage) ? rawUsage : 0, |
There was a problem hiding this comment.
if the cap is zero and the supplied != 0 (e.g. after a gov freeze), shouldn't usage be 100%?
General Changes
reserve-overviewto use theaave-sdk.ModalWrapper, which would impact other modals not present on this page.Developer Notes
This version isn’t 100% complete. We’re still missing a few fields that aren’t exposed by the SDK:
interestRateStrategyAddress(ALREADY ADDED)isolationModeConfig.debtCeiling.amountandisolationModeConfig.totalBorrows.usd(ALREADY ADDED)reserve.unbackedandreserve.unbackedUSDare not available in the SDK (SOLVED)Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files