Skip to content

fix: ens refactor#2907

Merged
foodaka merged 2 commits intomainfrom
fix/ens-lookup
Mar 19, 2026
Merged

fix: ens refactor#2907
foodaka merged 2 commits intomainfrom
fix/ens-lookup

Conversation

@grothem
Copy link
Collaborator

@grothem grothem commented Mar 17, 2026

General Changes

  • Refactors ENS name look up to use viem utilities
  • Updated proposal voter list to support ENS avatars

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview, Comment Mar 18, 2026 2:22pm

Request Review

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.19 MB (🟡 +39.54 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 65.41 KB (🟢 -9 B) 1.25 MB
/404 2.86 KB (🟢 -2 B) 1.19 MB
/500 3.19 KB (🟡 +1 B) 1.19 MB
/bridge 29.03 KB (🟢 -4 B) 1.22 MB
/dashboard 55.23 KB (🟢 -7 B) 1.24 MB
/faucet 15.2 KB (🟢 -6 B) 1.2 MB
/governance 78.26 KB (🟢 -237 B) 1.27 MB
/governance/ipfs-preview 101.97 KB (-2 B) 1.29 MB
/governance/v3/proposal 122.36 KB (🟢 -224 B) 1.31 MB
/history 36.15 KB (🟡 +1 B) 1.22 MB
/markets 40.25 KB (-4 B) 1.23 MB
/reserve-overview 24.1 KB (🟡 +6 B) 1.21 MB
/safety-module 29.68 KB (-1 B) 1.22 MB
/sgho 88.08 KB (🟡 +3 B) 1.27 MB
/staking 33.78 KB (-1 B) 1.22 MB
/v3-migration 36.62 KB (🟢 -4 B) 1.22 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@foodaka foodaka merged commit 3e74f20 into main Mar 19, 2026
27 checks passed
@foodaka foodaka deleted the fix/ens-lookup branch March 19, 2026 15:25
foodaka added a commit that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants