Skip to content

chore: market switcher#2924

Merged
foodaka merged 1 commit intomainfrom
chore/xlayer-market-switcher
Apr 6, 2026
Merged

chore: market switcher#2924
foodaka merged 1 commit intomainfrom
chore/xlayer-market-switcher

Conversation

@foodaka
Copy link
Copy Markdown
Collaborator

@foodaka foodaka commented Apr 6, 2026

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copilot AI review requested due to automatic review settings April 6, 2026 07:54
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
interface Ready Ready Preview, Comment Apr 6, 2026 7:58am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the front-end market switcher’s custom display ordering so the new X Layer market appears in the intended position within the dropdown sorting.

Changes:

  • Adds X Layer to MARKET_ORDER_BY_TITLE and shifts subsequent order indices accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +133 to +136
'X Layer': 10,
Polygon: 11,
Gnosis: 12,
Aptos: 13,
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description still contains placeholder text (e.g., “Fixes XYZ bug”, “Adds XYZ feature”, “…”). Please update it to describe the actual user-facing behavior change (adding X Layer into the custom market ordering) so reviewers and release notes are accurate.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.15 MB (🟡 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@foodaka foodaka merged commit 29f5922 into main Apr 6, 2026
31 checks passed
@foodaka foodaka deleted the chore/xlayer-market-switcher branch April 6, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants