compaso: fix sigman units, change sigmav units (sigmav3d unaffected) #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sigman_comandsigman_L2comwere having their values inappropriately multiplied by the box size inCompaSOHaloCatalog. These fields are the square roots of the eigenvalues of the second moment tensor formed from the unit vectors of the halo particle positions, so they should be dimensionless.Also,
sigmav{Min,Mid,Maj,rad,tan}_{L2com,com}were all being unpacked as redshift-space displacements (units of comoving Mpc/h). We unpack all other velocity fields as proper km/s, so let's do the same for those.sigmav3d_{L2com,com}are unaffected, as are the eigenvectors.