Merged
Conversation
- Remove mv_/mo_ prefixes from all DATA attributes - Move client and helper methods from PUBLIC to PROTECTED section - Rename method names: set_view→view_display, z2ui5_on_*→on_*, render_tab_*→view_display, ui5_*→clean names - Replace single quotes with backticks for all string literals - Fix blank lines in class definitions and method bodies per coding conventions - Use IF/ELSEIF lifecycle chain instead of IF/RETURN + CASE patterns - Use inline check_on_event for ≤3 events, CASE for ≥4 events - Extract view_display for apps where main() would exceed 50 lines - Rename ty_row→ty_s_row, ty_chart→ty_s_chart, add ty_t_rows where used twice - Replace && concatenation with string templates where variables are embedded - Always use client->check_app_prev_stack() for shownavbutton https://claude.ai/code/session_01HH52uVT6bQkXiuRChb1pz7
- Remove CREATE PUBLIC, mv_ prefixes, z2ui5_ method prefixes - Replace single quotes with backticks throughout - Convert && with variables to string templates where possible - Apply lifecycle chain (check_on_init / check_on_navigated / check_on_event) - Extract view_display for large apps; inline for simple apps - Fix declaration order: TYPES → DATA → METHODS per section - Move client ref to PROTECTED SECTION in all apps - Rename ty_row → ty_s_row in 028 and 030 - 027: pre-compute path bindings; use && for complex binding expressions that cannot be placed inside string template expressions - 025: extract view_display with CASE on show_view; add check_on_init branch - 024: add missing check_on_init branch; 4 events → on_event with CASE - 030: extract view_display (~100 lines); remove BUTTON_ROUNDTRIP dummy https://claude.ai/code/session_01HH52uVT6bQkXiuRChb1pz7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.