Clean up code style and remove unnecessary ICF check#612
Merged
Conversation
Remove redundant STRING conversions (app_058, app_130) and add missing spaces before backtick literals (app_069, app_098, app_104, app_202, app_202_0). https://claude.ai/code/session_01Cm8k1AzFsT9476zatCr5U4
Remove SELECT on unknown system table icfservloc (check_syntax) along with the conditional ICF warning strip, and use positional parameters for the three default-parameter calls (omit_parameter_name). https://claude.ai/code/session_01Cm8k1AzFsT9476zatCr5U4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies code style improvements and removes an obsolete ICF service availability check across multiple demo apps.
Key Changes
Removed ICF service check in
z2ui5_cl_demo_app_s_03_0: Eliminated theSELECTquery checking if the/SAP/PUBLIC/BC/ABAP/mime_demoICF service is active and the associated warning message, as this check is no longer necessary.Simplified method calls by removing unnecessary
CONVtype conversions:z2ui5_cl_demo_app_130: RemovedCONV #()when passinglr_tab->field_domatoget_txt()andlr_tab->fieldto_event()z2ui5_cl_demo_app_058: RemovedCONV string()when passinglr_field->titletotext()Improved code formatting for consistency:
id =testinstead of `id =`test)client->_event(STEP22)instead ofclient->_event(STEP22))vbox(sapUiSmallMargin)instead ofvbox( class =sapUiSmallMargin))Updated method calls to use positional arguments where appropriate:
view->_z2ui5( )->focus(inputApp)instead offocus( focusid =inputApp)vbox->text(The magic key is: abap2UI5)instead oftext( text = ... )Files Modified
src/99/z2ui5_cl_demo_app_s_03_0.clas.abapsrc/z2ui5_cl_demo_app_130.clas.abapsrc/99/z2ui5_cl_demo_app_202_0.clas.abapsrc/z2ui5_cl_demo_app_058.clas.abapsrc/z2ui5_cl_demo_app_069.clas.abapsrc/z2ui5_cl_demo_app_098.clas.abapsrc/z2ui5_cl_demo_app_104.clas.abapsrc/z2ui5_cl_demo_app_202.clas.abapAll changes align with the SAP ABAP Style Guide and project conventions.
https://claude.ai/code/session_01Cm8k1AzFsT9476zatCr5U4