-
Notifications
You must be signed in to change notification settings - Fork 24
Lazy loading of checkbox treeviewer in ModifiedObjectSelection page of PullWizard #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy loading of checkbox treeviewer in ModifiedObjectSelection page of PullWizard #299
Conversation
shubhamWaghmare-sap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some naming changes and also some use case evaluation.
Also modify the description to also included where is this change required i.e. in the pull wizard and in the object selection page.
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
shubhamWaghmare-sap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Please revert the object name for repositoryModifiedObject and one more comment regarding Lazy loading constant.
Apart from that update the title and description of the PR.
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
...adt.ui/src/org/abapgit/adt/ui/internal/wizards/AbapGitWizardPageObjectsSelectionForPull.java
Outdated
Show resolved
Hide resolved
…ndling change in check logic, pdeTest added
shubhamWaghmare-sap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Enhanced Object Selection checkbox tree
Overview
This update introduces lazy loading, parent–child checkbox synchronization, and state persistence to improve performance and usability when handling large repositories in modifiedObjectSelectionPage in Pull Wizard.
Key Changes
Lazy Loading on Scroll
repoOffsets,tryLazyLoad(), andloadNextBatch()to dynamically load data as the user scrolls.Parent–Child Checkbox Sync
"1"action objects remain permanently checked (cannot be unselected).Checkbox State Persistence
selectedObjectsForRepositorytracking after every selection change.Logical Selection