Skip to content

Conversation

@aarnapant-sap
Copy link
Collaborator

@aarnapant-sap aarnapant-sap commented Oct 30, 2025

Enhanced Object Selection checkbox tree

Overview

This update introduces lazy loading, parent–child checkbox synchronization, and state persistence to improve performance and usability when handling large repositories in modifiedObjectSelectionPage in Pull Wizard.


Key Changes

  • Lazy Loading on Scroll

    • Added incremental loading of child objects in batches of 100 per repository.
    • Introduced repoOffsets, tryLazyLoad(), and loadNextBatch() to dynamically load data as the user scrolls.
  • Parent–Child Checkbox Sync

    • Selecting a parent now selects all children.
    • Unselecting any child automatically unchecks the parent.
    • "1" action objects remain permanently checked (cannot be unselected).
  • Checkbox State Persistence

    • Selections persist correctly even after lazy loading or view refresh.
    • Updated selectedObjectsForRepository tracking after every selection change.
  • Logical Selection

    • Instead of relying on checkstate of object for pulling, current implementation focuses on the logical selection which prevents UI freezes for large repositories when parent is selected.

Copy link
Collaborator

@shubhamWaghmare-sap shubhamWaghmare-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some naming changes and also some use case evaluation.
Also modify the description to also included where is this change required i.e. in the pull wizard and in the object selection page.

Copy link
Collaborator

@shubhamWaghmare-sap shubhamWaghmare-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
Please revert the object name for repositoryModifiedObject and one more comment regarding Lazy loading constant.
Apart from that update the title and description of the PR.

@aarnapant-sap aarnapant-sap changed the title Lazy loading of checkbox treeviewer with text search Lazy loading of checkbox treeviewer in ModifiedObjectSelection page of PullWizard Nov 12, 2025
Copy link
Collaborator

@shubhamWaghmare-sap shubhamWaghmare-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@shubhamWaghmare-sap shubhamWaghmare-sap merged commit 52129c7 into abapGit:master Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants