Skip to content

Content handler: Flush / Close xml streams #2 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
absap merged 1 commit into from
Aug 24, 2018
Merged

Content handler: Flush / Close xml streams #2 #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions org.abapgit.adt.backend/src/org/abapgit/adt/backend/internal/RepositoryContentHandlerV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,25 @@ public Class<IRepository> getSupportedDataType() {
@Override
public IMessageBody serialize(IRepository repository, Charset charset) {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
XMLOutputFactory xmlOutputFactory = XMLOutputFactory.newInstance();
XMLStreamWriter xmlStreamWriter;
XMLStreamWriter xmlStreamWriter = null;
try {
String encoding = charset == null ? null : charset.name();
xmlStreamWriter = xmlOutputFactory.createXMLStreamWriter(outputStream, encoding);
xmlStreamWriter = XMLOutputFactory.newInstance().createXMLStreamWriter(outputStream, encoding);
xmlStreamWriter.writeStartDocument(null, encoding);
new RepositorySerializer().serializeRepository(repository, xmlStreamWriter, getSupportedContentType());
xmlStreamWriter.writeEndDocument();
xmlStreamWriter.flush();
return new ByteArrayMessageBody(getSupportedContentType(), outputStream.toByteArray());
} catch (XMLStreamException e) {
throw new ContentHandlerException("Error serializing repository", e); //$NON-NLS-1$
} finally {
if (xmlStreamWriter != null) {
try {
xmlStreamWriter.close();
} catch (XMLStreamException e) {
// ignore
}
}
}
}

Expand Down