chore: remove redundant version input from manual workflow triggers#42
Merged
ThePlenkov merged 3 commits intomainfrom Mar 2, 2026
Merged
chore: remove redundant version input from manual workflow triggers#42ThePlenkov merged 3 commits intomainfrom
version input from manual workflow triggers#42ThePlenkov merged 3 commits intomainfrom
Conversation
Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
…h/tag selector Co-authored-by: ThePlenkov <6381507+ThePlenkov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] React to comments on pull request 41
chore: remove redundant Mar 2, 2026
version input from manual workflow triggers
Review Summary by QodoSimplify workflow ref resolution and remove redundant version inputs
WalkthroughsDescription• Remove redundant version input from workflow_dispatch triggers • Replace bash ref resolution step with inline expression • Eliminate injection risk and unused GH_TOKEN variable • Update input descriptions to reflect actual fallback behavior Diagramflowchart LR
A["workflow_dispatch<br/>with version input"] -->|removed| B["Built-in branch/tag selector"]
C["Bash resolve-ref step<br/>with GH_TOKEN"] -->|replaced| D["Inline expression<br/>inputs.version || github.ref_name"]
E["Misleading descriptions<br/>defaults to latest release"] -->|updated| F["Accurate descriptions<br/>defaults to triggered ref"]
B --> G["Simplified workflows"]
D --> G
F --> G
File Changes1. .github/workflows/docker.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish,publish-gpr, anddockerworkflows had aversioninput onworkflow_dispatchthat duplicated GitHub's built-in branch/tag selector. The fallback logic also embedded${{ github.ref_name }}directly in a bash script (injection risk) and kept an unusedGH_TOKENenv var aftergh release viewwas removed.Changes
workflow_dispatch: Removedversioninput from all three workflows — the UI branch/tag picker is sufficientworkflow_call: Retainedversioninput — still required byrelease.ymlto pass the newly created tag downstreamref:GH_TOKENenv var in one gogithub.ref_name) instead of the now-removed "latest release" default💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.