Skip to content

Updated project settings, Fixed issues for dynamic framework#37

Closed
amosavian wants to merge 1 commit intoabbeycode:masterfrom
amosavian:master
Closed

Updated project settings, Fixed issues for dynamic framework#37
amosavian wants to merge 1 commit intoabbeycode:masterfrom
amosavian:master

Conversation

@amosavian
Copy link
Copy Markdown

@amosavian amosavian commented Dec 18, 2016

This pull request addressed framework issues discussed in abbeycode/UnzipKit#48 allows project to be used for manual dynamic linking.

@amosavian amosavian changed the title Updated project settings, Fixed issues for dynamic framework using Updated project settings, Fixed issues for dynamic framework usage Dec 18, 2016
@amosavian amosavian changed the title Updated project settings, Fixed issues for dynamic framework usage Updated project settings, Fixed issues for dynamic framework Dec 18, 2016
@abbeycode
Copy link
Copy Markdown
Owner

abbeycode commented Dec 22, 2016

Can you please merge in upstream changes that fixed the build?

abbeycode
abbeycode reviewed Dec 22, 2016
View reviewed changes
Comment thread Resources/UnrarKit-Info.plist
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>2.8-beta</string>
Copy link
Copy Markdown
Owner

@abbeycode abbeycode Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it out of beta after we merge this request. I've got a scripted process for doing so.

abbeycode
abbeycode reviewed Dec 22, 2016
View reviewed changes
Comment thread UnrarKit.xcodeproj/project.pbxproj
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
LastUpgradeCheck = 0700;
Copy link
Copy Markdown
Owner

@abbeycode abbeycode Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were any of the changes to this file required for the framework to build?

Copy link
Copy Markdown
Author

@amosavian amosavian Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will only make a warning silent. Nothing special.

abbeycode
abbeycode reviewed Dec 22, 2016
View reviewed changes
Comment thread UnrarKit.xcodeproj/xcshareddata/xcschemes/UnrarKit iOS.xcscheme
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0700"
LastUpgradeVersion = "0820"
Copy link
Copy Markdown
Owner

@abbeycode abbeycode Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this

Copy link
Copy Markdown
Author

@amosavian amosavian Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will only make a warning silent. Nothing special.

abbeycode
abbeycode reviewed Dec 22, 2016
View reviewed changes
Comment thread UnrarKit.xcodeproj/xcshareddata/xcschemes/UnrarKit.xcscheme
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0700"
Copy link
Copy Markdown
Owner

@abbeycode abbeycode Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this

Copy link
Copy Markdown
Author

@amosavian amosavian Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@abbeycode abbeycode self-assigned this Dec 22, 2016
@abbeycode abbeycode added this to the 2.8 milestone Dec 22, 2016
@abbeycode
Copy link
Copy Markdown
Owner

abbeycode commented Dec 22, 2016 •
edited
Loading

Thanks for the contribution - as far as I can tell though, the additional import is the only change required though, right? That's basically what all of my individual comments were getting at.

@amosavian
Copy link
Copy Markdown
Author

amosavian commented Dec 22, 2016

In general it adds TargetConditionals.h to umbrella header, remove beta tag from version, and change LastUpgrade to Xcode 8.2 to silence a warning

@abbeycode
Copy link
Copy Markdown
Owner

abbeycode commented Dec 22, 2016

Right, so for the beta tag and LastUpgrade flag, those are things that I'd rather take care of myself.

For removing "beta", I will do that after merging this PR. For the version upgrade, I need to check over all the upgraded settings. It shouldn't take me long, but I can't promise a timeframe. I'll try to look at it soon.

@amosavian
Copy link
Copy Markdown
Author

amosavian commented Dec 22, 2016

Consequently only TargetConditionals.h to umbrella header left. I appreciate if you add it too.

@amosavian
Copy link
Copy Markdown
Author

amosavian commented Dec 22, 2016

Also you can switch to Foundation from UIKit and Cocoa if the lib didn't used anything special to these frameworks. Makes it compatible with even future Apple OSes. Which means TargetConditionals.h not necessary anymore.

@abbeycode
Copy link
Copy Markdown
Owner

abbeycode commented Dec 27, 2016

Good call on using Foundation. I made that switch, and pushed a new build to CocoaPods (everything is at 2.8 now, no longer beta).

@abbeycode abbeycode closed this Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbeycode abbeycode abbeycode left review comments

Assignees

@abbeycode abbeycode

Labels

enhancement

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

2 participants

@amosavian @abbeycode