Skip to content

Remove Minizip from UnzipKit headers#22

Merged
abbeycode merged 3 commits intoabbeycode:masterfrom
iblacksun:master
Nov 18, 2015
Merged

Remove Minizip from UnzipKit headers#22
abbeycode merged 3 commits intoabbeycode:masterfrom
iblacksun:master

Conversation

@iblacksun
Copy link
Copy Markdown
Contributor

Remove Minizip from UnzipKit Header.

So now UnzipKit can using in Swift Frameworks.

@iblacksun iblacksun changed the title Master Remove Minizip from UnzipKit headers Nov 9, 2015
@abbeycode
Copy link
Copy Markdown
Owner

Hey, so is this what DTS recommended as the solution to #21? Also, please note that this pull request broke the build. Looking at the Travis logs, it seems that the unit tests are failing to build.

@abbeycode abbeycode self-assigned this Nov 10, 2015
@abbeycode
Copy link
Copy Markdown
Owner

Will you be able to take a look at the unit test build failure? Let me know if you can't, and I can take a look.

@iblacksun
Copy link
Copy Markdown
Contributor Author

@abbeycode I have no experience with Travis CI. Could you take a look at it?

@abbeycode
Copy link
Copy Markdown
Owner

There's really not anything to learn with Travis, it's just running a command line build. You almost certainly don't need to change the way the build is actually configured. Before I look, can you try running the unit tests locally and see if it works? If it doesn't (the logs indicate the unit tests aren't successfully building on your branch), then fix it and push. You should see the warning below that "All checks have failed" go away.

If you still would rather I take a look, I'll see what's going on with it.

@iblacksun
Copy link
Copy Markdown
Contributor Author

@abbeycode OK, Thanks you very much. I will try to fix this and request your help if have any question.

fixed test case.
@iblacksun
Copy link
Copy Markdown
Contributor Author

@abbeycode Now Travis CI all checks have passed. Please check it again.

@abbeycode
Copy link
Copy Markdown
Owner

Hey, thanks for tackling it. I've made a few changes on the swift-framework branch. It looks like your UnzipKitIssue project builds fine with it. Can you please take a look? If it looks good, I'll merge to master and cut a new release.

If you're interested in the reasons for the specific changes I made, let me know, and I can annotate your PR with inline comments.

@iblacksun
Copy link
Copy Markdown
Contributor Author

@abbeycode I've check UnzipKitIssue project and can build fine now.

Thanks.

@abbeycode abbeycode merged commit 379de0d into abbeycode:master Nov 18, 2015
@abbeycode
Copy link
Copy Markdown
Owner

This has been incorporated into v1.6. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants