Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test server setup in several test classes to use the newer
WebApplicationand minimal API patterns introduced in ASP.NET Core, replacing the olderHostBuilderandIApplicationBuilderapproach. This change simplifies server configuration, makes the test code more concise, and aligns it with modern ASP.NET Core best practices.Test server setup modernization:
HostBuilderandIApplicationBuilderwithWebApplication.CreateBuilder()and minimal API endpoint mapping (e.g.,app.MapGet,app.MapPost) inTestApiServer,TestOAuthServer, andTestClientCredentialsServer, as well as in integration test helpers. This results in less boilerplate and easier-to-read test server setup. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Test helper refactoring:
CreateHostAsyncin integration tests to useWebApplicationand minimal APIs, improving consistency and reducing code duplication. [1] [2] [3]Type and method signature updates:
WebApplicationinstead ofIApplicationBuilderto match the new server setup approach. [1] [2]These changes modernize the test infrastructure, making it easier to maintain and extend in the future.