Added test case for serialized (pickled) batch reader fragments for SAM #124
+1,569
−1,435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvictus
force-pushed
the
conrad/pickle-test
branch
2 times, most recently
from
3b7a2be to
229ae4e
Compare
style: Formatting Update lockfile
nvictus
force-pushed
the
conrad/pickle-test
branch
from
229ae4e to
198032d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regression tests reproducing a bug where unpickled batch reader fragments had separate scanner instances sharing a file-like Python object instance that would cause issues when trying to materialize the fragments. @nvictus has a PR with the fix - once that's merged I will rebase on
mainand the Python tests should pass.