refactor: Rename format/ to scanner/ and nest batch_iterator under it#163
Merged
nvictus merged 1 commit intoabdenlab:mainfrom Mar 6, 2026
Merged
refactor: Rename format/ to scanner/ and nest batch_iterator under it#163nvictus merged 1 commit intoabdenlab:mainfrom
nvictus merged 1 commit intoabdenlab:mainfrom
Conversation
Restructure each format family's internal modules from: <family>/format/ (scanner structs) <family>/batch_iterator/ (iteration impl) <family>/model/ (data model) to: <family>/scanner/ (scanners + batch iterators) <family>/model/ (data model) This better reflects what the modules contain: scanners are the primary abstraction, and batch iterators are their implementation detail. Also deduplicate resolve_chrom_id into alignment/scanner.rs (shared by sam, bam, cram) and gxf/scanner.rs (shared by gff, gtf). Public API unchanged — all re-exports preserved at the family level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure each format family's internal modules from:
/format/ (scanner structs)
/batch_iterator/ (iteration impl)
/model/ (data model)
to:
/scanner/ (scanners + batch iterators)
/model/ (data model)
This better reflects what the modules contain: scanners are the primary abstraction, and batch iterators are their implementation detail.
Also deduplicate resolve_chrom_id into alignment/scanner.rs (shared by sam, bam, cram) and gxf/scanner.rs (shared by gff, gtf).
Public API unchanged — all re-exports preserved at the family level.