Widen BGZF trait bounds on scanners#164
Merged
nvictus merged 1 commit intoabdenlab:mainfrom Mar 6, 2026
Merged
Conversation
Replace concrete noodles::bgzf::io::Reader<R> with a generic R bounded
by noodles::bgzf::io::{BufRead, Seek} in scan_query, scan_unmapped, and
scan_virtual_ranges across all format scanners. This allows callers to
pass either the serial bgzf::io::Reader or the parallel
bgzf::io::MultithreadedReader without any wrapper changes.
Add tests for BAM scanning with MultithreadedReader (scan + scan_query).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace concrete
noodles::bgzf::io::Reader<R>with a generic R bounded bynoodles::bgzf::io::{BufRead, Seek}in scan_query, scan_unmapped, and scan_virtual_ranges across all format scanners.This allows callers to pass either the serial
bgzf::io::Readeror the parallelbgzf::io::MultithreadedReaderwithout any wrapper changes.Add tests for BAM scanning with MultithreadedReader (scan + scan_query).