feat: Add sample nesting option to VariantModel#170
Merged
nvictus merged 1 commit intoabdenlab:mainfrom Mar 16, 2026
Merged
Conversation
Add a flag to control whether genotype columns are top-level (unnested, current default) or wrapped in a single "samples" struct column. - `unnest_samples=true` (default): N top-level sample/field columns (preserves existing behavior) - `unnest_samples=false`: single "samples" struct column containing all genotype data Threaded through Model → Scanner → BatchBuilder → PyO3 → Python API and R bindings. When nested, `project(["samples"])` treats the column as an atomic unit. Model definition (samples, genotype_defs) still controls the inner structure. The default is slated to flip to `false` in a future release, at which point users opt into unnesting explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flag to control whether sample/genotype columns are top-level (unnested, current default) or wrapped in a single "samples" struct column. re: #167
unnest_samples=true(default): N top-level sample/field columns (preserves existing behavior)unnest_samples=false: single "samples" struct column containing all genotype dataThreaded through Model → Scanner → BatchBuilder → PyO3 → Python API and R bindings. When nested,
project(["samples"])treats the column as an atomic unit. Model definition (samples, genotype_defs) still controls the inner structure.The default is slated to flip to
falsein a future release, at which point users opt into unnesting explicitly.