fix(embedding): set kv_unified=True when embedding=True to enable batch processing#2217
Merged
abetlen merged 2 commits intoMay 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2216
Problem
When using
embedding=True,n_seq_maxis set to 256 butkv_unifiedremains
False(the default). This causesn_ctx_seqto be computedas
n_ctx / n_seq_max = 256tokens per sequence, making batchembeddings essentially unusable for inputs longer than 256 tokens.
Fix
Set
self.context_params.kv_unified = Trueinside theif embedding:block, which allows each sequence to use the full context window
instead of
n_ctx / n_seq_max.Testing
Verified that both single and batch embeddings work correctly after
the fix: