Closed
Conversation
Check NTP responses if they don't have unsychronized leap and require that the root distance has a reasonable value to ignore servers that would be ignored by some widely used NTP clients (e.g. ntpd using default tos mindist).
Owner
|
Very nice, thank you. I'll merge it and tweak it a little so the bad responses gets logged accordingly with the 'score', too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check NTP responses if they don't have unsychronized leap and require that the root distance has a reasonable value to ignore servers that would be ignored by some widely used NTP clients (e.g. ntpd using
default tos mindist).
This should affect only a very small number of servers, which for some reason report a large root delay or dispersion, but still have an offset small enough to keep a good score. I think I saw two or three. This check could be useful in case there is a large-scale DoS attack on the pool servers (e.g. exploiting some of the vulnerabilities that were found in ntpd in the past) which would leave them unsynchronized.
This should partially work with net-ntp which doesn't report the fractional part of root dispersion (fixed in abh/net-ntp#2). The check will be just less sensitive, i.e. root dispersion has to reach 2 seconds.