Skip to content

Various fixes and updates to website#235

Merged
abh merged 1 commit intoabh:mainfrom
PoolMUC:fixes-and-updates-website
Jul 13, 2024
Merged

Various fixes and updates to website#235
abh merged 1 commit intoabh:mainfrom
PoolMUC:fixes-and-updates-website

Conversation

@PoolMUC
Copy link
Copy Markdown
Contributor

@PoolMUC PoolMUC commented Jul 13, 2024

Fixed typos, improved wordings, updated translations, updated URLs and links, upgraded URL schemata, ...

@abh
Copy link
Copy Markdown
Owner

abh commented Jul 13, 2024

Very nice! Will you leave a comment when you are stopping for the day? Looks like you keep finding more!

Fixed typos, improved wording, updated translations,
updated URLs and links, upgraded URL schemata, ...
@PoolMUC
Copy link
Copy Markdown
Contributor Author

PoolMUC commented Jul 13, 2024

Will you leave a comment when you are stopping for the day? Looks like you keep finding more!

Yeah, I think I will stop now...

Sorry, I'll use a different approach next time, e.g., explore use of the "work in progress/draft" feature.

@PoolMUC
Copy link
Copy Markdown
Contributor Author

PoolMUC commented Jul 13, 2024

In the language-specific join.html files, there is a code fragment starting with [% i = 0; FOR server = combust.servers_with_urls; %]. It seems that is broken somehow. At least in my browsers, it only shows the introductory "Here are a few servers with traffic/load graphs:" (or respective translated) text, but not the promised/expected graphs.

I don't know how to fix this. If unfixable (e.g., because the backend system has changed and no longer provides the needed data/functionality), it could probably be removed.

@abh
Copy link
Copy Markdown
Owner

abh commented Jul 13, 2024

Yeah, I think I will stop now...

Sorry, I'll use a different approach next time, e.g., explore use of the "work in progress/draft" feature.

No apologies necessary, I really appreciate this!

@abh
Copy link
Copy Markdown
Owner

abh commented Jul 13, 2024

Ah yeah, the "server_with_urls" thing was a feature where operators could provide links to their server graphs / metrics, but I was worried about spam / junk, so I never made it so users could input the links on their own and whatever links were there were on servers no longer in the pool.

I think we could just remove that feature; it's not clear it's worth bringing back.

@PoolMUC
Copy link
Copy Markdown
Contributor Author

PoolMUC commented Jul 13, 2024

I think we could just remove that feature

Ok. I am working on another PR addressing some further minor nits, will address it there, and push once you have committed the current PR (just so I can better keep track of what is already addressed, and what is still open - and smaller PRs make for better reviewing... - unless you prefer to have further commits added to the current PR).

@abh abh merged commit ea62293 into abh:main Jul 13, 2024
@PoolMUC PoolMUC deleted the fixes-and-updates-website branch July 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants