Skip to content

Fix Vietnamese translation#247

Merged
abh merged 6 commits intoabh:mainfrom
tnhung2011:fix-vietnamese-trans
Jun 6, 2025
Merged

Fix Vietnamese translation#247
abh merged 6 commits intoabh:mainfrom
tnhung2011:fix-vietnamese-trans

Conversation

@tnhung2011
Copy link
Copy Markdown
Contributor

@tnhung2011 tnhung2011 commented Dec 8, 2024

@abh Following your request for me to fix the use.html file (#246), I have fixed a disclosing tag. The file should now work as expected.

Also I'm a bit curious about some translations' inclusion into the beta site. Is there any criteria for them to be included in the main one?

(EDIT: Sorry for the open-close-open ping-pong, I just did it to fix some translation errors)

L13: <code/> -> </code>
@tnhung2011 tnhung2011 marked this pull request as draft December 8, 2024 04:59
@tnhung2011 tnhung2011 changed the title Fix disclosing tag in Vietnamese translation Fix Vietnamese translation Dec 8, 2024
@tnhung2011 tnhung2011 marked this pull request as ready for review December 8, 2024 05:47
@abh
Copy link
Copy Markdown
Owner

abh commented Jun 5, 2025

@tnhung2011 I usually include everything on the beta site; it's defined in lib/NTPPool/Control.pm and remove the "beta" flag there when it looks reasonable (which I need help to judge since I'm only mostly sorta fluent in Danish and English!)

@abh abh requested a review from Copilot June 5, 2025 23:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several Vietnamese translation issues in the i18n and documentation files related to pool.ntp.org. The key changes include updating the translation for "News," fixing a disclosing tag in the use.html file, and adjusting the language and punctuation in the join.html file for clarity.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
i18n/vi.po Updated translation for "News" from "Tin tức" to "Bản tin".
docs/ntppool/vi/use.html Revised translation text and fixed a malformed HTML tag.
docs/ntppool/vi/join.html Adjusted phrasing and punctuation, including correcting an email typo.
Comments suppressed due to low confidence (1)

docs/ntppool/vi/join.html:43

  • There appears to be a typo in the email address ('develooper' should likely be 'developer').
href="mailto:ask@develooper.com">ask@develooper.com</a>.

Comment thread docs/ntppool/vi/use.html Outdated
Comment thread docs/ntppool/vi/join.html Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@abh abh merged commit 267bbc8 into abh:main Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants