Implement retry logic with exponential backoff for OpenID discovery document fetching #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement retry logic with exponential backoff for OpenID discovery document fetching
Summary
This PR adds retry logic with exponential backoff to the
get_discovery_doc()function to address intermittent SSL connection errors duringAuthClientinitialization. The specific error being addressed is:Key Changes:
HTTPAdapterandRetryfrom urllib3 with 3 max retries (configurable)backoff_factor=1[429, 500, 502, 503, 504]requests.Sessionwith mounted retry adapterReview & Testing Checklist for Human
AuthClientcreation still works normally and doesn't introduce performance regressionsAuthClientErrorimmediately without unnecessary retriesNotes
max_retries=3withbackoff_factor=1means delays of ~1s, 2s, 4s between retriesrequests.Session- monitor for any unexpected side effectsRequested by: @abhay-codeium
Link to Devin run: https://app.devin.ai/sessions/e9482c54c5c44fe58afd4384cb2a6624