Skip to content

Fixes Infrastructure issues & libvirt arch change#49

Merged
abhibongale merged 1 commit into
mainfrom
phase-1-foundation
May 25, 2026
Merged

Fixes Infrastructure issues & libvirt arch change#49
abhibongale merged 1 commit into
mainfrom
phase-1-foundation

Conversation

@abhibongale
Copy link
Copy Markdown
Owner

  • parsing issues & SELinux permission issues.
  • healthcheck.sh not founded
  • Console scripts not created
  • Auto-detected docker/podman
  • detected running libvirt default network
  • Syntax error and Validation error
  • Added logic to add VM already exists or not.
  • podman-compose timeout issue in compose.py

Fixes: #39, #41, #42, #43, #44, #45, #46, #47, #48
Closes: #40

Description

Related Issue

Fixes #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Checklist

  • My code follows the style guidelines of this project (black, ruff)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Testing

Unit Tests

pytest tests/unit/ -v

Code Quality

black --check stackbox/ tests/
ruff check stackbox/ tests/
mypy stackbox/core/compose.py

Coverage

pytest --cov=stackbox --cov-report=term-missing

Screenshots (if applicable)

Additional Notes

@abhibongale abhibongale self-assigned this May 25, 2026
@abhibongale abhibongale added bug Something isn't working enhancement New feature or request labels May 25, 2026
@abhibongale abhibongale force-pushed the phase-1-foundation branch 5 times, most recently from 2634c0f to 4c80608 Compare May 25, 2026 13:56
- parsing issues & SELinux permission issues.
- healthcheck.sh not founded
- Console scripts not created
- Auto-detected docker/podman
- detected running libvirt default network
- Syntax error and Validation error
- Added logic to add VM already exists or not.
- podman-compose timeout issue in compose.py

Fixes: #39, #41, #42, #43, #44, #45, #46, #47, #48
Closes: #40
Signed-off-by: Abhishek Bongale <abhishekbongale@outlook.com>
@abhibongale abhibongale force-pushed the phase-1-foundation branch from 4c80608 to 8e2002a Compare May 25, 2026 14:02
Copy link
Copy Markdown
Owner Author

@abhibongale abhibongale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhibongale abhibongale merged commit 1859a35 into main May 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Architecture change we should follow kubevirt.io sb init test-job --ironic-repo ~/ironic failed due to infrastructure issues.

1 participant