Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46916d18f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "nssh": "abizer/tap" | |||
There was a problem hiding this comment.
This migration entry does not actually redirect anything because the destination resolves back to the same fully-qualified name (abizer/tap/nssh). In Homebrew’s migration resolver (Formulary.tap_formula_name_type / CaskLoader.tap_cask_token_type), migration handling only triggers when the computed new_tapped_name differs from the original; with this value, it remains unchanged, so brew upgrade nssh for existing formula installs will still look for a formula that was just deleted and fail instead of moving users to the cask.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch — you're right. I confirmed this against Formulary.tap_formula_name_type / CaskLoader.tap_cask_token_type: when the destination tap equals the source tap the migration is a no-op, so {"nssh": "abizer/tap"} doesn't redirect anything.
Dropped the file in 2be6b82. Existing formula users will need a one-time brew uninstall nssh && brew install --cask abizer/tap/nssh; the PR description now calls that out explicitly. There isn't a clean Homebrew primitive for same-tap formula→cask migration, and this is a small enough tap that documenting the manual step is fine.
The nssh release pipeline now publishes a Homebrew cask under Casks/ instead of a formula (goreleaser is phasing out `brews:` in favor of `homebrew_casks:`). Drop the old formula and add tap_migrations.json so existing `brew install abizer/tap/nssh` users get redirected to the cask on next upgrade. DO NOT MERGE until a post-migration nssh release has actually written Casks/nssh.rb to this tap — otherwise `brew install abizer/tap/nssh` will 404 in the gap between formula deletion and first cask publish. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codex review pointed out (correctly) that a tap_migrations.json entry mapping `nssh` -> `abizer/tap` is a no-op: Homebrew's migration resolver only fires when the destination tap differs from the source. Same-tap formula -> cask isn't something tap_migrations.json can express, so the file does nothing. Existing formula users will need a one-time `brew uninstall nssh && brew install --cask abizer/tap/nssh`. The PR description has been updated to call that out. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
abizer
force-pushed
the
nssh-cask-migration
branch
from
2be6b82 to
1f41294
Compare
1 participant
Summary
Companion to abizer/nssh#8, which switches the nssh release pipeline from
brews:tohomebrew_casks:.Formula/nssh.rb(stale at v2.1.0; goreleaser will no longer update it). OnceCasks/nssh.rbis published by the next release,brew install abizer/tap/nsshwill resolve to the cask automatically.tap_migrations.jsonwas originally part of this PR but Codex correctly pointed out that same-tap formula→cask migrations are a no-op there (Homebrew's migration resolver only fires when the destination tap differs). It's been dropped.Anyone with the old formula installed will need to run, one time:
```
brew uninstall nssh
brew install --cask abizer/tap/nssh
```
Do not merge this until a post-migration nssh release has actually written
Casks/nssh.rbto this tap. Sequence:Otherwise there's a window where `brew install abizer/tap/nssh` 404s.
Test plan
🤖 Generated with Claude Code