RBD primary storage 연결시 + 및 / 기호를 -와 _ 로 변경하는 로직 개선#91
Merged
dhslove merged 1 commit intoablecloud-team:mainfrom Oct 20, 2021
Merged
RBD primary storage 연결시 + 및 / 기호를 -와 _ 로 변경하는 로직 개선#91dhslove merged 1 commit intoablecloud-team:mainfrom
dhslove merged 1 commit intoablecloud-team:mainfrom
Conversation
dhslove
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace multiple + and / symbols by - and _ to have URL-safe base64 going to the API
PR 설명
When adding RBD primary storage, if secret contains only one "+" and one "/" symbol, It replace to "-" and "" correctly.
However, if secret contains many "+" and "/" symbols, it replace only one first symbol to "-" and "".
RBD primary storage를 연결시 secret에 하나의 "+"와 "/"기호가 포함된 경우 정상적으로 "-" 와 "_"로 변경합니다.
하지만 다수의 "+"와 "/" 기호가 들어온 경우 정상적으로 처리하지 못하고 처음 발견한 문자들만 변경하던 문제를 해결하였습니다.
변경 구분
기능/개선 규모 또는 버그 심각도
기능/개선 규모
버그 심각도
스크린샷
테스트 방법 및 결과