Closed
Conversation
These get sanitized by DOMPurify, we need to put them back
…webvtt-unsanitize #692 Parse timestamp tags in WebVTT
With this change, translations do not *depend* on translations being present, and while missing translations with log console errors, they will not error out the player. Fixes #682. Also helps with maintenance and translation, as the actual text is available when manipulating code.
Removes Cookie package from all demos. Fixes #671
This was only here to patch in missing support for `aria-label`, and is overriden by that. Fixes #659.
Requires a switch from array to object data for langs, to provide language names.
See #680. The script-defined sizes make responsive handling more difficult. Modern CSS does a better job here.
Default design is a left-aligned small image. Other styles would have to be custom. Fixes #555
If window is offscreen left, set to position 0. If it's offscreen right, align right edge of window to right edge of viewport. Behaves slightly differently on left than right; the goal is to keep the options toggle visible. Fixes #657
Adds a prototype to replace $.deferred. Minor remapping so that all resolutions return a single object instead of multiple vars.
Follow up to #709
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to move these to develop. Committed to wrong branch.