[Bug] After entering the message if you hit Enter multiple times in a row, the message gets sent multiple times

[andriy-ah]

Steps to reproduce:

1. Enter message in the input box
2. Hit enter a few times quickly
3. See message has been sent multiple times

Also it seems the message appears in the messages list only after a successful network request. So there is a visible delay (you hit enter and see message remains in the message input for a while).

Expected behavior:

• Message appears in the messages list immediately and only once
• Actual request to send message happens asynchronously, so that the message is sent after it appears in the message list (optimistic approach)
• If there is some error with sending message, the error is shown in the messages list, like in all popular messengers

[andriy-ah]

Hi @sacOO7, is there anyone actively working on this repo?

[sacOO7]

Thanks for bringing this up. Yes, it’s actively maintained—we’ll review it and get back to you.

[andriy-ah]

Thank you, appreciate it. I added a couple of other items yesterday.

[splindsay-92]

@andriy-ah Thanks for reporting the issue with the input box, we will have a fix for this up soon. In regards to your other points on expected behaviour..

• The MessageInput component requires the REST request to complete, but it does not require the same message to be received back over the websocket connection before performing the optimistic update. The response from the server contains non-client generated data, such as the serial, that is required to build a message object and to apply correct ordering. It is highly recommended to await the REST response, that said, we are looking at ways to make it easy to swap out components as needed - so you could override the behaviour of a single component (in your case the MessageInput) without having to re-implement its parent components too.

Generally the send latency should be such that the REST request resolves within 10's of ms, are you consistently seeing much larger times?

[andriy-ah]

Thank you @splindsay-92. It lasts about 150-200ms for me (on fast internet).
At least the message should disappear from the input box immediately after hitting Enter, now it seems it stays until response comes.
Personally, I think it makes sense for the message to appear in the messages list also immediately (like in messengers there are delivery and read checkboxes, but the message is already in the list).