Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/commands/apps/rules/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export default class RulesUpdateCommand extends ControlBaseCommand {
"$ ably apps rules update chat --persisted",
"$ ably apps rules update chat --mutable-messages",
"$ ably apps rules update events --push-enabled=false",
"$ ably apps rules update events --no-push-enabled",
'$ ably apps rules update notifications --persisted --push-enabled --app "My App"',
"$ ably apps rules update chat --persisted --json",
];
Expand Down
5 changes: 2 additions & 3 deletions src/commands/auth/keys/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ export default class KeysCreateCommand extends ControlBaseCommand {
`$ ably auth keys create --name "My New Key" --capabilities '{"channel1":["publish","subscribe"],"channel2":["history"]}'`,
`$ ably auth keys create --name "My New Key" --json`,
`$ ably auth keys create --name "My New Key" --pretty-json`,
`$ ably auth keys create --app <appId> --name "MyKey" --capabilities '{"channel:*":["publish"]}'`,
`$ ably auth keys create --app <appId> --name "MyOtherKey" --capabilities '{"channel:chat-*":["subscribe"],"channel:updates":["publish"]}' --ttl 86400`,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ttl flag isn't supported

`$ ably auth keys create --name "My New Key" --capabilities '{"channel1":["publish","subscribe"],"channel2":["history"]}'`,
`$ ably auth keys create --app APP_ID --name "MyKey" --capabilities '{"channel:*":["publish"]}'`,
`$ ably auth keys create --app APP_ID --name "MyOtherKey" --capabilities '{"channel:chat-*":["subscribe"],"channel:updates":["publish"]}'`,
];

static flags = {
Expand Down
2 changes: 1 addition & 1 deletion src/commands/channels/presence/enter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default class ChannelsPresenceEnter extends AblyBaseCommand {
};

static override description =
"Enter presence on a channel and remains present until terminated.";
"Enter presence on a channel and remain present until terminated";

static override examples = [
"$ ably channels presence enter my-channel",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/channels/presence/subscribe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default class ChannelsPresenceSubscribe extends AblyBaseCommand {

static override examples = [
"$ ably channels presence subscribe my-channel",
'$ ably channels presence subscribe my-channel --client-id "filter123"',
'$ ably channels presence subscribe my-channel --client-id "my-client"',
"$ ably channels presence subscribe my-channel --json",
"$ ably channels presence subscribe my-channel --pretty-json",
"$ ably channels presence subscribe my-channel --duration 30",
Expand Down
5 changes: 4 additions & 1 deletion src/commands/integrations/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ export default class IntegrationsUpdateCommand extends ControlBaseCommand {
const existingRule = await controlApi.getRule(appId, args.ruleId);

// Prepare update data - explicitly typed
const updatePayload: Partial<Omit<PartialRuleData, "status">> = {
const updatePayload: Partial<PartialRuleData> = {
...(flags.status && {
status: flags.status === "enabled" ? "enabled" : "disabled",
}),
...(flags["request-mode"] && { requestMode: flags["request-mode"] }),
...(flags.source && {
source: JSON.parse(flags.source) as Record<string, unknown>,
Expand Down
4 changes: 2 additions & 2 deletions src/commands/logs/channel-lifecycle/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default class LogsChannelLifecycleIndexCommand extends BaseTopicCommand {
"Stream logs from [meta]channel.lifecycle meta channel";

static override examples = [
"ably logs channel-lifecycle subscribe",
"ably logs channel-lifecycle subscribe --rewind 10",
"$ ably logs channel-lifecycle subscribe",
"$ ably logs channel-lifecycle subscribe --rewind 10",
];
}
4 changes: 2 additions & 2 deletions src/commands/logs/connection-lifecycle/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default class LogsConnectionLifecycleIndexCommand extends BaseTopicComman
"Stream logs from [meta]connection.lifecycle meta channel";

static override examples = [
"ably logs connection-lifecycle subscribe",
"ably logs connection-lifecycle subscribe --rewind 10",
"$ ably logs connection-lifecycle subscribe",
"$ ably logs connection-lifecycle subscribe --rewind 10",
];
}
2 changes: 1 addition & 1 deletion src/commands/rooms/presence/enter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default class RoomsPresenceEnter extends ChatBaseCommand {
};

static override description =
"Enter presence in a chat room and remain present until terminated.";
"Enter presence in a chat room and remain present until terminated";

static override examples = [
"$ ably rooms presence enter my-room",
Expand Down
Loading