[SDK-3336] - exchange Parameter for AmqpExternalTarget struct#24
Merged
graham-russell merged 1 commit intomainfrom Dec 13, 2023
Merged
Conversation
graham-russell
changed the title
AmqpExternalTarget struct
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
from
392194a to
5548c85
Compare
graham-russell
changed the title
AmqpExternalTarget structexchange Parameter for AmqpExternalTarget struct
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
from
5548c85 to
4db308f
Compare
surminus
reviewed
Dec 11, 2023
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
from
4db308f to
ecc3a13
Compare
surminus
reviewed
Dec 11, 2023
surminus
approved these changes
Dec 11, 2023
Contributor
surminus
left a comment
surminus
left a comment
There was a problem hiding this comment.
Trailing quote but otherwise seems ok
Add the `exchange` parameter to the `AmqpExternalTarget` struct. This has been implemented in the Control API and will be exposed in the Ably Terraform provider.
graham-russell
force-pushed
the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
from
ecc3a13 to
164517f
Compare
graham-russell
deleted the
feature/SDK-3336-amqpexternal-rule-exchange-param
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
exchangeparameter to theAmqpExternalTargetstruct. This has been implemented in the Control API and will be exposed in the Ably Terraform provider.Infra ticket is INF-3251