Skip to content

[ECO-4820] fix(ConnectionManager): update the connection close implementation to follow RTN12f#1013

Merged
ttypic merged 2 commits intomainfrom
ECO-4820/fix-imidiate-closing
Jun 17, 2024
Merged

[ECO-4820] fix(ConnectionManager): update the connection close implementation to follow RTN12f#1013
ttypic merged 2 commits intomainfrom
ECO-4820/fix-imidiate-closing

Conversation

@ttypic
Copy link
Copy Markdown
Contributor

@ttypic ttypic commented Jun 14, 2024 •
edited
Loading

Resolves #1012

When CONNECTING state moves immediately to CLOSING we wait CONNECTED protocol message before sending CLOSE.

@ttypic ttypic requested a review from AndyTWF June 14, 2024 13:35
@github-actions github-actions bot temporarily deployed to staging/pull/1013/features June 14, 2024 13:35 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1013/javadoc June 14, 2024 13:36 Inactive
@ttypic ttypic force-pushed the ECO-4820/fix-imidiate-closing branch from 7ac3b82 to 171419e Compare June 14, 2024 13:49
@sacOO7
Copy link
Copy Markdown
Collaborator

sacOO7 commented Jun 14, 2024

I think we should add explicit test for this PR

@github-actions github-actions bot temporarily deployed to staging/pull/1013/features June 14, 2024 13:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1013/javadoc June 14, 2024 13:50 Inactive
@ttypic
[ECO-4820] fix(ConnectionManager): update the connection close implem…
baa76d6 
…entation to follow RTN12f

When `CONNECTING` state, moves immediately to `CLOSING` we wait `CONNECTED` protocol message before sending `CLOSE`.
@ttypic ttypic force-pushed the ECO-4820/fix-imidiate-closing branch from 171419e to baa76d6 Compare June 15, 2024 09:33
@github-actions github-actions bot temporarily deployed to staging/pull/1013/features June 15, 2024 09:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1013/javadoc June 15, 2024 09:35 Inactive
sacOO7
sacOO7 reviewed Jun 17, 2024
View reviewed changes
Comment thread lib/src/test/java/io/ably/lib/test/realtime/ConnectionManagerTest.java
@github-actions github-actions bot temporarily deployed to staging/pull/1013/features June 17, 2024 09:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1013/javadoc June 17, 2024 09:51 Inactive
@ttypic ttypic force-pushed the ECO-4820/fix-imidiate-closing branch from 84bf0be to 816520e Compare June 17, 2024 09:54
@github-actions github-actions bot temporarily deployed to staging/pull/1013/features June 17, 2024 09:54 Inactive
@ttypic @sacOO7
[ECO-4820] chore(tests): add more checks
478e524 
Co-authored-by: sachin shinde <sachinshinde7676@gmail.com>
@ttypic ttypic force-pushed the ECO-4820/fix-imidiate-closing branch from 816520e to 478e524 Compare June 17, 2024 09:55
sacOO7
sacOO7 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ttypic ttypic merged commit 7166263 into main Jun 17, 2024
@ttypic ttypic deleted the ECO-4820/fix-imidiate-closing branch June 17, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyTWF AndyTWF AndyTWF approved these changes

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connection remains open when close is sent immediately

3 participants

@ttypic @sacOO7 @AndyTWF